David Caro has posted comments on this change.

Change subject: automation: Keep xunit report
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/46643/3/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 15: make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
Line 16: 
Line 17: find "$BUILDS" \
Line 18:     -iname \*.rpm \
Line 19:     -exec mv {} "$EXPORTED_ARTIFACTS/" \;
his will not work, as build-artifacts.sh will be run independently too (the 
fact that check-patch runs it is to avoid duplicating the code).

Any of the three main scripts (check-patch, check-merged and build-artifacts) 
should be able to run without any parameters or expecting any env vars (aside 
from posix ones, $PWD $HOME and such)
Line 20: find "$PWD" \
Line 21:     -maxdepth 1 \
Line 22:     -iname vdsm\*.tar.gz \


-- 
To view, visit https://gerrit.ovirt.org/46643
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6eaed1a42e67059e457969d785e70b08efb5f2f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to