Nir Soffer has posted comments on this change. Change subject: qemuimg: add support for convert progress ......................................................................
Patch Set 11: Code-Review+1 (2 comments) Just minor commit message cleanup. https://gerrit.ovirt.org/#/c/33910/11//COMMIT_MSG Commit Message: Line 11: order to parse and maintain the progress of the process. Line 12: Line 13: operation = qemuimg.convert(srcImage, dstImage) Line 14: Line 15: while not command.operation: commmand.operation -> operation.finished or convert.finished (since you are using qemuimg.convert in the example) Line 16: operation.wait(10) Line 17: log.debug('command progress: %s%%', operation.progress) Line 18: Line 19: Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299 Line 13: operation = qemuimg.convert(srcImage, dstImage) Line 14: Line 15: while not command.operation: Line 16: operation.wait(10) Line 17: log.debug('command progress: %s%%', operation.progress) command -> operation, or convert Line 18: Line 19: Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299 -- To view, visit https://gerrit.ovirt.org/33910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
