Ondřej Svoboda has posted comments on this change. Change subject: hooks: ovs: move libvirt configuration into a separate module ......................................................................
Patch Set 4: Code-Review-1 (6 comments) Thank you for the previous round of improvements – and sorry for further nagging! https://gerrit.ovirt.org/#/c/46910/4//COMMIT_MSG Commit Message: Line 12: all other configurations are already done almost all configuration is completed (uncountable; at first, I even read/understood "configurators" and was confused). Line 12: so eventual rollback : don't have to do extra job so an eventual rollback doesn't have to do any extra work Line 13: in for the following https://gerrit.ovirt.org/#/c/46910/4/vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py File vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py: Line 20: import six six is a third-party package – this is why I usually put it after standard library imports, here it would follow libvirt. Line 43: True Just guessing, is this "bridged"? Please give names to parameters so we don't have to divine what they are :-) Line 50: six.iteritems The reason I suggested itervalues (and not iteritems) is that "net" is not used. -- To view, visit https://gerrit.ovirt.org/46910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I775edc776c738822ed955ffb0b7885dae450b667 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
