Yaniv Bronhaim has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/44494/16/lib/vdsm/m2cutils.py File lib/vdsm/m2cutils.py: Line 164: def _loadCAs(self): Line 165: context = self.context Line 166: Line 167: if self.ca_certs: Line 168: context.load_verify_locations(self.ca_certs) less related and can get in before this patch Line 169: context.set_verify( Line 170: mode=SSL.verify_peer | SSL.verify_fail_if_no_peer_cert, Line 171: depth=10, Line 172: callback=self._verify) https://gerrit.ovirt.org/#/c/44494/16/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: try: instead of rely on ImportError why not to have - https://gerrit.ovirt.org/#/c/44689/15/lib/vdsm/config.py.in here and just check it to know what to import Line 21: from . import m2cutils as sslutils Line 22: from .m2cutils import SSLHandshakeDispatcher Line 23: from .m2cutils import SSLSocket Line 24: except ImportError: https://gerrit.ovirt.org/#/c/44494/16/vdsm.spec.in File vdsm.spec.in: Line 42: %global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d Line 43: %endif Line 44: Line 45: # enable m2crypto by default Line 46: %global with_m2c 1 I still prefer to require m2crypto always to keep the spec less complicated to understand. and why not? you have it in debian as well.. its just implementation thing that we want to avoid Line 47: Line 48: # Gluster should not be shipped with RHEV Line 49: %if ! 0%{?rhev_build} Line 50: %global with_gluster 1 -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
