Francesco Romani has submitted this change and it was merged.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
......................................................................
vdsm-tool: Do not panic with sanlock empty groups
This fixes the following error:
File "/usr/lib/python2.6/site-packages/vdsm/tool/configurators/
sanlock.py", line 87, in isconfigured
.strip().split(" ")]
ValueError: invalid literal for int() with base 10: ''
Which happens when sanlock "Groups:" line is empty:
$ grep "Groups:" /proc/<sanlock pid>/status
Groups:
Sanlock must have its groups properly setup, but we should not
blow up because of this.
Fixed by using split() instead of split(' '), which cannot handle empty
string and is the wrong way to split in most cases.
Change-Id: I47f080beb748353970dec0753c9a0a7b1dd09bc6
Bug-Url:https://bugzilla.redhat.com/1267444
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Germano Veit Michel <germ...@redhat.com>
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46742
Reviewed-by: Francesco Romani <from...@redhat.com>
Continuous-Integration: Dan Kenigsberg <dan...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47104
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik <amure...@redhat.com>
---
M lib/vdsm/tool/configurators/sanlock.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47f080beb748353970dec0753c9a0a7b1dd09bc6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
