Dan Kenigsberg has posted comments on this change. Change subject: build: Introduce --enable-gluster configuration ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46708/1/vdsm.spec.in File vdsm.spec.in: Line 13: # Glusterfs package version Line 14: %global gluster_version 3.7.1 Line 15: Line 16: # Glusterfs - overridable using rpmbuild --define "with_gluster 1" Line 17: %{!?with_gluster: %global with_gluster 0} > vdsm-gluster is needed only for gluster project when they like to use vdsm ovirt upstream should keep building vdsm-gluster. THAT is the typical use case. Our downstream split of RHEV/RHS is indeed not much of an interest to the upstream spec, but we'd like to keep downstream builders happy. Please maintain the current behaviour of asking them to set a single flag, not too. Line 18: Line 19: # koji build - overridable using rpmbuild --define "fedora_koji_build 1" Line 20: %{!?fedora_koji_build: %global fedora_koji_build 0} Line 21: -- To view, visit https://gerrit.ovirt.org/46708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84608625e3b004c64b4928e5325d9375fb952878 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
