Petr Horáček has posted comments on this change. Change subject: net: tests: test_rollback ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/46875/6/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2777: self.assertBondDoesntExist(BONDING_NAME, nics) Line 2778: Line 2779: @cleanupNet Line 2780: @ValidateRunningAsRoot Line 2781: def test_rollback(self): > what? didn't we have already this trivial test? Oops. ConnectivityCheck test tests if rollback was done and if it removed all created networks (but it does not check reverting to initial networks) Line 2782: with dummyIf(3) as nics: Line 2783: NET1 = NETWORK_NAME + '1' Line 2784: NET2 = NETWORK_NAME + '2' Line 2785: -- To view, visit https://gerrit.ovirt.org/46875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71bc067c5f9f828a0a8899005be51c3695d81c20 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
