Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: ignore unknown message id ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43746/4/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 295: def requestDone(self, response): Line 296: try: Line 297: del self._requests[response.id] Line 298: except KeyError: Line 299: # ignore when response had no id I'm still not convinced that this condition is so common and so benign that we want to swallow it with no log. What is the probable scenario where this could happen? Line 300: # we wouldn't be able to match it Line 301: # with request on the client side Line 302: pass Line 303: self.addResponse(response) -- To view, visit https://gerrit.ovirt.org/43746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
