Ido Barkan has posted comments on this change. Change subject: net: retry ifup if an error occured ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47327/4/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 807: # BZ: 1259468. In case of failed ifup, try it again after a second. Line 808: # This problem should be resolved with systemd v220. This code is meant Line 809: # to be just a proof of our suspicion. If this does not solve the Line 810: # problem on test server, remove it. Line 811: # NOTE: should we report the first or second error? yes. it will be very helpful to get a log about if up retrying. for any error, we will get an error log anyway. Line 812: sleep(1) Line 813: rc2, _, _ = utils.execCmd(cmd, raw=False) Line 814: Line 815: if rc2 != 0: -- To view, visit https://gerrit.ovirt.org/47327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90650d027d03b494673544d6d8cab7b381ddc917 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
