Nir Soffer has posted comments on this change. Change subject: tests: v2v: add test for commit fb4c72a ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Nice, tiny cleanup would be even nicer. https://gerrit.ovirt.org/#/c/47364/2/tests/v2vTests.py File tests/v2vTests.py: Line 88: Line 89: def storageVolLookupByPath(self, name): Line 90: if self._storage_lookup_fail: Line 91: e = fake.Error(libvirt.VIR_ERR_INTERNAL_ERROR) Line 92: raise e raise fakeError(...)? Line 93: return LibvirtMock.Volume() Line 94: Line 95: class Volume(object): Line 96: def info(self): -- To view, visit https://gerrit.ovirt.org/47364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad523dc7c34276c6811513220cd7230ca5fc6e45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
