Federico Simoncelli has uploaded a new change for review. Change subject: Remove superfluous macros in the specfile ......................................................................
Remove superfluous macros in the specfile In this patch: * remove the redundant %attr macros for the vdsm hooks * set the %defattr ownership to root:root Signed-off-by: Federico Simoncelli <[email protected]> Change-Id: Ia6af1c10fc35d2e30c2ef9ba319d035631cf7108 --- M vdsm.spec.in 1 file changed, 47 insertions(+), 47 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/7651/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 0d1b195..ec4028c 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -747,82 +747,82 @@ %if 0%{?with_hooks} %files hook-directlun -%defattr(-, vdsm, kvm, -) -%attr (440,root,root) %{_sysconfdir}/sudoers.d/50_vdsm_hook_directlun -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_directlun -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_directlun -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_directlun +%defattr(-, root, root, -) +%{_sysconfdir}/sudoers.d/50_vdsm_hook_directlun +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_directlun +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_directlun +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_directlun %files hook-fileinject -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_fileinject +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_fileinject %files hook-floppy -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_floppy -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_floppy +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_floppy +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_floppy %files hook-hostusb -%defattr(-, vdsm, kvm, -) -%attr (440,root,root) %{_sysconfdir}/sudoers.d/50_vdsm_hook_hostusb -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_hostusb -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_hostusb -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_hostusb +%defattr(-, root, root, -) +%{_sysconfdir}/sudoers.d/50_vdsm_hook_hostusb +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_hostusb +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_hostusb +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_hostusb %files hook-hugepages -%defattr(-, vdsm, kvm, -) -%attr (440,root,root) %{_sysconfdir}/sudoers.d/50_vdsm_hook_hugepages -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_hugepages -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_hugepages -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_hugepages +%defattr(-, root, root, -) +%{_sysconfdir}/sudoers.d/50_vdsm_hook_hugepages +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_hugepages +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_hugepages +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_hugepages %files hook-isolatedprivatevlan -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_isolatedprivatevlan +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_isolatedprivatevlan %config(noreplace) %{_sysconfdir}/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml %files hook-numa -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_numa +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_numa %files hook-pincpu -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_pincpu +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_pincpu %files hook-promisc -%defattr(-, vdsm, kvm, -) -%attr (440,root,root) %{_sysconfdir}/sudoers.d/50_vdsm_hook_promisc -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_start/50_promisc -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_destroy/50_promisc +%defattr(-, root, root, -) +%{_sysconfdir}/sudoers.d/50_vdsm_hook_promisc +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_start/50_promisc +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_destroy/50_promisc %files hook-qos -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_qos +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_qos %files hook-scratchpad -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_scratchpad -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_scratchpad -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_scratchpad +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_scratchpad +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_scratchpad +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_scratchpad %files hook-smartcard -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_smartcard +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_smartcard %files hook-smbios -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_smbios +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_smbios %files hook-sriov -%defattr(-, vdsm, kvm, -) -%attr (440,root,root) %{_sysconfdir}/sudoers.d/50_vdsm_hook_sriov -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_sriov -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_sriov -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_sriov +%defattr(-, root, root, -) +%{_sysconfdir}/sudoers.d/50_vdsm_hook_sriov +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_sriov +%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_sriov +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_sriov %files hook-vmdisk -%defattr(-, vdsm, kvm, -) -%attr (755,vdsm,kvm) %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vmdisk +%defattr(-, root, root, -) +%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vmdisk %endif %files debug-plugin -- To view, visit http://gerrit.ovirt.org/7651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6af1c10fc35d2e30c2ef9ba319d035631cf7108 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
