Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46970/1/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 271: os.unlink(__VDSM_ID) Line 272: Line 273: if not os.path.exists(__VDSM_ID): Line 274: with open(__VDSM_ID, 'wt') as f: Line 275: f.write(str(self.uuid)) how could it ever NOT be a string? whomever attempted to set it to None or whatnot should be fixed, we need to add a blind conversion here. Line 276: Line 277: if utils.isOvirtNode(): Line 278: from ovirt.node.utils.fs import Config Line 279: Config().persist(__VDSM_ID) -- To view, visit https://gerrit.ovirt.org/46970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1f341dd66a468cf704158789e158f6d61f1d98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
