Dan Kenigsberg has posted comments on this change. Change subject: net: add simple network namespace functions to ipwrapper ......................................................................
Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46447/9/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 599: netns_command = [_IP_BINARY.cmd, 'netns', 'exec', netns_name] Line 600: _execCmd(netns_command + command) Line 601: Line 602: Line 603: def netns_assign(device, netns_name): sorry for the failed former attempt to review this function. It is a wrapper of `ip link set device netns`, and as such it should have a similar name to that of linkSet. How about def link_set_netns(dev, netns): return linkSet(dev, ['netns', netns] -- To view, visit https://gerrit.ovirt.org/46447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b83c9635fba4feb4946ceba460f3ab8c09ad656 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
