Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 18: (5 comments) https://gerrit.ovirt.org/#/c/44689/18//COMMIT_MSG Commit Message: Line 9: During build process we can choose to set default ssl implementation Line 10: which will be used during runtime. We can change the value which Line 11: implementation is used in runtime by updating config.py with: Line 12: - m2c - m2crypto is used Line 13: - ssl - standard ssl module is used > user should modify vdsm.conf and restart vdsm - config.py just declares the Done Line 14: Line 15: This setting do not apply for debian where we use ssl only. Line 16: Line 17: Line 11: implementation is used in runtime by updating config.py with: Line 12: - m2c - m2crypto is used Line 13: - ssl - standard ssl module is used Line 14: Line 15: This setting do not apply for debian where we use ssl only. > I don't understand this statement Will update Line 16: Line 17: Line 18: Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 https://gerrit.ovirt.org/#/c/44689/18/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 216: Line 217: ('ssl_implementation', '@SSl_IMPLEMENTATION@', Line 218: 'Specifies which ssl implementation should be used. ' Line 219: 'There are 2 options: ' Line 220: '"m2c" to use the m2crypto module (default) ' > I don't see a reason to state that its a default, as the default changes be Done Line 221: '"ssl" to use the standard python ssl module'), Line 222: ]), Line 223: Line 224: # Section: [mom] https://gerrit.ovirt.org/#/c/44689/18/vdsm.spec.in File vdsm.spec.in: Line 45: # M2C build - overrideable using rpmbuild --define "with_m2c 1" Line 46: %{!?with_m2c: %global with_m2c 0} Line 47: Line 48: %if %{with_m2c} Line 49: %global ssl_implementation 'm2c' > in fedora always use m2c as default. if user want ssl he modified vdsm.conf Done Line 50: %else Line 51: %global ssl_implementation 'ssl' Line 52: %endif Line 53: Line 620: -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \ Line 621: -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' vdsm/dsaversion.py Line 622: Line 623: sed -i -e 's/@SSl_IMPLEMENTATION@/%{ssl_implementation}/g' lib/vdsm/config.py Line 624: > why do we need it? over fedora (rpm installation) make it always m2c as def I will update. Line 625: %install Line 626: rm -rf %{buildroot} Line 627: make DESTDIR=%{buildroot} install Line 628: -- To view, visit https://gerrit.ovirt.org/44689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
