Ido Barkan has posted comments on this change. Change subject: net: Support VLAN hardware offloading in hostQOS ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47443/4/vdsm/network/tc/filter.py File vdsm/network/tc/filter.py: Line 170: Line 171: def _parse_ematch_match(first_arg, tokens): Line 172: if first_arg != 'vlan': Line 173: _parser.parse_skip_line(tokens) Line 174: # empty data. currently we do not support other ematches than vlan > but don't you want to eat all token up to the end of the line? this is what skip_line does Line 175: return {} Line 176: Line 177: data = {'object': first_arg} Line 178: for token in tokens: -- To view, visit https://gerrit.ovirt.org/47443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
