Ayal Baron has posted comments on this change. Change subject: Asynchronous LVM bootstrap on vdsm start ......................................................................
Patch Set 1: Looks good to me, approved Reviewed again. Gave +1 previously because now it is possible to run ops while bootstrap is going on, however, looking at the code lvm marks pvs vgs and lvs as stale to begin with so no matter which flow is started it will cause reload if it needs the info. However, note that this means that we might run extra operations now in case of such a race (between bootstrap and another operation running post connect). Solving this however seems like a premature optimization though (need to change bootstrap in lvm.py to take lock and check value of _stale and if not stale not reload) -- To view, visit http://gerrit.ovirt.org/7566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cbf1b8880cf2fb38f9de008f884fc0a2b92e004 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
