Francesco Romani has submitted this change and it was merged. Change subject: tests: Fix and simplify cleanup after failures ......................................................................
tests: Fix and simplify cleanup after failures If mount or umount failed, temporary images were not removed because of incorrect cleanup code. This was not an issue since the temporary files were created in a temporary directory, but we had two of them, so failures to remove the first would leave also the second. This patch simplify cleanup by removing the incorrect cleanup of the temporary images, as they are removed anyway when the temporary directory is removed. Instead of two temporary directories, we use now one directory, and create the two subdirectories inside it. Now we have to remove only one directory in tearDown. To make it easier to debug, the temporary directory is created with a prefix. Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2 Bug-Url: https://bugzilla.redhat.com/1267851 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46387 Continuous-Integration: Jenkins CI Reviewed-by: Shmuel Leib Melamud <[email protected]> Reviewed-by: Sandro Bonazzola <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/47326 Continuous-Integration: Francesco Romani <[email protected]> Tested-by: Francesco Romani <[email protected]> Reviewed-by: Francesco Romani <[email protected]> --- M tests/mkimageTests.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
