Francesco Romani has posted comments on this change. Change subject: tests: v2v: refactor tests to make it extensible ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/47366/3/tests/v2vTests.py File tests/v2vTests.py: Line 140: </VirtualSystem> Line 141: </Envelope>""" Line 142: Line 143: Line 144: VmSpec = namedtuple('VmSpec', ['name', 'vmid']) > Should be defined in the top, since we based all the tests on this. Done Line 145: Line 146: Line 147: class v2vTests(TestCaseBase): Line 148: Line 153: raise SkipTest('v2v is not supported current os version') Line 154: Line 155: vmspecs = tuple( Line 156: VmSpec("RHEL_%i" % i, str(uuid.uuid4())) Line 157: for i in range(self.NUM_VMS) > I don't think we need this loop and the constant. Just create a list of vm Done Line 158: ) Line 159: Line 160: def _connect(uri, username, passwd): Line 161: return LibvirtMock(vmspecs=vmspecs) -- To view, visit https://gerrit.ovirt.org/47366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0c2f9575debd328a2c8e0dacdb8e8dc845e340 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
