Dan Kenigsberg has posted comments on this change. Change subject: net: Report correct (guest) pci address fot hostdev interfaces. ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/47696/1/tests/devices/parsing/complex_vm_tests.py File tests/devices/parsing/complex_vm_tests.py: Line 76: 0000_05_00_1 nicer to check the host address as well. https://gerrit.ovirt.org/#/c/47696/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4423: network = source[0].getAttribute('network') Line 4424: network = network[len(netinfo.LIBVIRT_NET_PREFIX):] Line 4425: Line 4426: # Get nic address Line 4427: address = {} TODO: fix _getUnderlyingDeviceAddress and its users to have this code. Line 4428: for child in x.childNodes: Line 4429: if (child.nodeType != Node.TEXT_NODE and Line 4430: child.tagName == 'address'): Line 4431: address = dict((k.strip(), child.getAttribute(k).strip()) -- To view, visit https://gerrit.ovirt.org/47696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4542dd9e0a70db4b9a6526442118d610c1b2c615 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
