Dan Kenigsberg has posted comments on this change. Change subject: vdsm: isolate fake_kvm into a hook ......................................................................
Patch Set 4: Code-Review-1 (1 comment) partial "review". actually, it's only a glimpse. https://gerrit.ovirt.org/#/c/46897/4/vdsm/caps.py File vdsm/caps.py: Line 217: archTag = guestTag.find('arch') Line 218: if archTag.get('name') == arch: Line 219: return _findLiveSnapshotSupport(guestTag) Line 220: Line 221: logging.error("missing guest arch tag in the capabilities XML") does not seem intentional; at least I don't see the motivation of adding this log always. Line 222: Line 223: return None Line 224: Line 225: -- To view, visit https://gerrit.ovirt.org/46897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
