Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that subscriptions use uniqe id ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/46656/3/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 139: return Line 140: Line 141: ack = frame.headers.get("ack", stomp.AckMode.AUTO) Line 142: subscription = stomp._Subscription(dispatcher.connection, destination, Line 143: sub_id, ack, None) > not easier and better to raise exception here while you try to create the s We check for existence of a key in line #136 and send ERROR frame to a client if there is one. We do not create _Subscription instance in this situation. Line 144: Line 145: self._sub_dests[destination].append(subscription) Line 146: self._sub_ids[sub_id] = subscription Line 147: -- To view, visit https://gerrit.ovirt.org/46656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
