Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergance schedule
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/46940/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 365:                     self._vm,
Line 366:                     int(self._downtime),
Line 367:                     config.getint('vars', 'migration_downtime_steps'))
Line 368:                 with utils.running(downtimeThread):
Line 369:                     with utils.running(self._monitorThread):
> Only extracted to functions so on this place only one function will be call
It is absolutely fine to do this in a later patch.
Line 370:                         # we need to support python 2.6, so two 
nested with-s.
Line 371:                         self._perform_migration(duri, muri)
Line 372:             else:
Line 373:                  with utils.running(self._monitorThread):


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to