Ondřej Svoboda has posted comments on this change. Change subject: net: tests: test tc upper limit using iperf ......................................................................
Patch Set 20: (3 comments) Just nits. I can see IperfClient.out actually being used. https://gerrit.ovirt.org/#/c/46449/20/tests/tcTests.py File tests/tcTests.py: Line 37: vlan_device, requires_tc, : veth_pair, IperfServer, IperfClient, requires_iperf3, : requires_tun, bridge_device, network_namespace I prefer the order Classes, functions, alphabetically. Line 45: vdsm.utils utils goes after libvirtconnection (yeah, vdsm.constants and network.tc are also "wrongly" ordered) Line 489: \ We can do without slashes :-) -- To view, visit https://gerrit.ovirt.org/46449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9348a09e331195695c16862ef986df3b4abfa991 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
