Milan Zamazal has posted comments on this change. Change subject: vmstats: take in account missing bulk stats fields ......................................................................
Patch Set 3: Code-Review-1 (2 comments) Fine, just typos in the comment. https://gerrit.ovirt.org/#/c/47760/3/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 361: for idx in six.moves.xrange(stats.get('%s.count' % group, 0)): Line 362: try: Line 363: name = stats['%s.%d.name' % (group, idx)] Line 364: except KeyError: Line 365: # bulk stats accumulate what they can get, raising errors Bulk ... Line 366: # only in the critical cases. This includes fundamntal Line 367: # attributes like names, so count has to be considered Line 368: # an upper bound more like a precise indicator. Line 369: pass Line 362: try: Line 363: name = stats['%s.%d.name' % (group, idx)] Line 364: except KeyError: Line 365: # bulk stats accumulate what they can get, raising errors Line 366: # only in the critical cases. This includes fundamntal ... fundamental Line 367: # attributes like names, so count has to be considered Line 368: # an upper bound more like a precise indicator. Line 369: pass Line 370: else: -- To view, visit https://gerrit.ovirt.org/47760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0eae867305dead8a96a23801ff2429605522ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
