Dan Kenigsberg has posted comments on this change. Change subject: Remove imageID in diskstats collect ......................................................................
Patch Set 1: I would prefer that you didn't submit this But what if Engine somehow rely on this per-disk argument? Simplest approach would be to add it only if it exists. A more complex approach is to check with Engine if this is required. But maybe Federico's sharp memory can help here - why was this added? -- To view, visit http://gerrit.ovirt.org/7698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43171fefaf1e4e6b81420f95ed6bdd8ef65431b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
