Nir Soffer has uploaded a new change for review. Change subject: sdc: Rename method to make it less confusing ......................................................................
sdc: Rename method to make it less confusing StorageCache.refresh() does not do any refresh, but clearing the domain cahce and invlidating lvm cache (actually clearing it). Rename to clear() to reflect what it does. Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236 Signed-off-by: Nir Soffer <[email protected]> --- M vdsm/storage/sdc.py M vdsm/storage/sp.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/47916/1 diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py index ecb9708..a26c05a 100644 --- a/vdsm/storage/sdc.py +++ b/vdsm/storage/sdc.py @@ -181,7 +181,7 @@ return uuids - def refresh(self): + def clear(self): with self._syncroot: lvm.invalidateCache() self.__domainCache.clear() diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index b8fd8f3..6ecaf8d 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -627,7 +627,7 @@ self.id = hostID # Make sure SDCache doesn't have stale data (it can be in case of FC) sdCache.invalidateStorage() - sdCache.refresh() + sdCache.clear() # Rebuild whole Pool self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion) self.__createMailboxMonitor() @@ -1245,7 +1245,7 @@ 'msdUUID' - master storage domain UUID """ sdCache.invalidateStorage() - sdCache.refresh() + sdCache.clear() self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion) def updateVM(self, vmList, sdUUID): -- To view, visit https://gerrit.ovirt.org/47916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
