Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: replace import for persist/unpersist ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/47829/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 58 Line 59 Line 60 Line 61 Line 62 > Douglas, The best is always try to use the new code instead of the old one which brings the issue that vdsm cannot be started related in the description of patch or at least the import order should be: "Try first the new code and IF FAIL use the old". I believe at this time, it's safe enough to deprecate and remove the old code but Fabian can give the final ack. -- To view, visit https://gerrit.ovirt.org/47829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
