Yaniv Bronhaim has posted comments on this change. Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/functional/xmlrpcTests.py Line 185: except Exception: Line 186: self._cleanupStorage(rollback) Line 187: raise Line 188: Line 189: @testValidation.ValidateRunningAsRoot This attribute doesn't work.. I ran it not as Root and it tried to run this test anyway Line 190: def testLocalStorage(self): Line 191: storageHandle = self._setupStorage() -- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
