Yaniv Bronhaim has posted comments on this change. Change subject: init: configure multipath on upgrade from ovirt-3.5 ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47941/1/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 261: ret=$? Line 262: elif grep -q '^vdsm-4\.16\.' "${upgraded_ver_file}"; then Line 263: # We need to treat the upgrade from 4.16.x specifically Line 264: # by running manual multipath configure command Line 265: "$VDSM_TOOL" configure --module multipath > mmm right ... iirc --force won't configure libvirt if its already configure ok, checked it - libvirt will restart if we run configure --force. if sanlock config or sebool config won't change between 3.5 to 3.6 we're safe. so I agree to keep it only to multipath. Line 266: ret=$? Line 267: fi Line 268: [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}" Line 269: fi -- To view, visit https://gerrit.ovirt.org/47941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbebdebb6bda25606b20d91804977fa8eb7f13e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
