Dan Kenigsberg has posted comments on this change. Change subject: Adding python3 run for nosetests ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/48051/7/automation/check-patch.packages File automation/check-patch.packages: Line 12: python-devel Line 13: python-inotify Line 14: python-ioprocess Line 15: python-netaddr Line 16: python3-netaddr let's have a simple LOCALE=C sort here Line 17: python-nose Line 18: python3-nose Line 19: python-pep8 Line 20: python-pthreading https://gerrit.ovirt.org/#/c/48051/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 30: from collections import namedtuple, deque Line 31: from contextlib import contextmanager Line 32: from fnmatch import fnmatch Line 33: try: Line 34: from StringIO import StringIO python 2.7 already has io.StringIO. If io.StringIO is safe for our usecase, we should always import it. Line 35: except ImportError: Line 36: from io import StringIO Line 37: from weakref import proxy Line 38: from .compat import pickle Line 630: controlling thread dies, which may not be what you intended: if you create Line 631: a temporary thread, spawn a sync=False sub-process, and have the thread Line 632: finish, the new subprocess would die immediately. Line 633: """ Line 634: from cpopen import CPopen this ugly movement should be explained and justified in the commit message. Line 635: Line 636: command = cmdutils.wrap_command(command, with_ioclass=ioclass, Line 637: ioclassdata=ioclassdata, with_nice=nice, Line 638: with_setsid=setsid, with_sudo=sudo, https://gerrit.ovirt.org/#/c/48051/7/vdsm.spec.in File vdsm.spec.in: Line 101: six why six? 19:53:28 error: Failed build dependencies: -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
