Nir Soffer has posted comments on this change. Change subject: Adding toolTests.py to python3 check modules ......................................................................
Patch Set 7: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/48052/7/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 22: import os Line 23: import tempfile Line 24: import re Line 25: import selinux Line 26: from six.moves import configparser as ConfigParser Keep python3 name, rename usage of old name. Line 27: import io Line 28: Line 29: from .. import utils Line 30: Line 262: Line 263: def read(self, path): Line 264: with open(path, 'r') as f: Line 265: return self.wrapped.readfp( Line 266: io.StringIO(u'[root]\n' + f.read()) Are you sure it works for both 2 and 3? -- To view, visit https://gerrit.ovirt.org/48052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
