Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Streamline fake blockSD creation ......................................................................
tests: Streamline fake blockSD creation The BlockManifestTests test various functions of the BlockStorageDomainManifest by creating a mock blockSD using FakeLVM. Some tests created the storage domain's VG and others did not. None of these tests created the other internal LVs needed for a properly functioning SD (ie. metadata, ids, etc.). In order to unify the testing environment and prepare for additional sophistication in FakeLVM, converge make_vg and make_blocksd_manifest into a new function make_blocksd which does everything needed. While sometimes we will set up more than is strictly necessary for some tests, the advantage of unified setup is far more important. Change-Id: I0cc0aef3a77da9e7d81ded85f0c7e8b21cb2b990 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/47914 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> --- M tests/manifest_tests.py M tests/storagetestlib.py 2 files changed, 26 insertions(+), 36 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cc0aef3a77da9e7d81ded85f0c7e8b21cb2b990 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
