Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: hoststats: don't inherit from thread ......................................................................
sampling: hoststats: don't inherit from thread Inheriting from Thread is bad practice. This patch makes sampling.HostStatsThread use a thread attribute, favoring composition over inheritance. No intended functional changes. Change-Id: I0ddb419e8d64612e8b035c359f5679c376113f9a Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/47943 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Jenkins CI --- M tests/samplingTests.py M vdsm/virt/sampling.py 2 files changed, 14 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/47943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ddb419e8d64612e8b035c359f5679c376113f9a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
