Ido Barkan has posted comments on this change. Change subject: hooks: ovs: add script name to log ......................................................................
Patch Set 4: Code-Review-1 (1 comment) just for visibility (found a possible glitch on ovs_before_network_setup_ovs.py), other then that, it's okay. https://gerrit.ovirt.org/#/c/46916/4/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 129: vlan abusing this patch for letting you know that this parameter isn't used- is this a bug? or just a forgotten parameter? -- To view, visit https://gerrit.ovirt.org/46916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e40406fb2dfce6099a2c288b5d3c37ceec839d1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
