Nir Soffer has posted comments on this change. Change subject: lib: executor: make possible to name work tasks ......................................................................
Patch Set 5: Code-Review-1 (2 comments) Should work, but I'm not fan of adding stuff to Worker, when the callable already have this data, or can hold it. https://gerrit.ovirt.org/#/c/48191/5/lib/vdsm/executor.py File lib/vdsm/executor.py: Line 184 Line 185 Line 186 Line 187 Line 188 Here - we log the task - don't we get good logs from this? Line 211: if self._discarded: Line 212: raise AssertionError("Attempt to discard worker twice") Line 213: self._discarded = True Line 214: self._log.debug("Worker %s discarded while doing '%s'", Line 215: self.name, self._task_name) Cant we log the task? if you want better debugging, use a callable with __str__ method. Even plain function should be clear enough. Line 216: self._executor._worker_discarded(self) Line 217: Line 218: Line 219: class TaskQueue(object): -- To view, visit https://gerrit.ovirt.org/48191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40584ee9a99839a4cb56d2f4d908d274f3a46638 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
