Nir Soffer has posted comments on this change. Change subject: gluster: Set mount path based on gluster volume info ......................................................................
Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/48308/6//COMMIT_MSG Commit Message: Line 9: There are cases where gluter server and ovirt are configured Line 10: differently regarding ip addresses and domain names. To avoid Line 11: any issues that could happen due to this misconfiguration, we Line 12: have to use info retuned from gluster volume info to set the Line 13: mount path as well as the backup-volfile-servers. This describes the previous solution, and not the current version of the patch. Please update the commit message to reflect what this patch does, and why. Line 14: Line 15: Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Line 16: Bug-Url: https://bugzilla.redhat.com/1278880 https://gerrit.ovirt.org/#/c/48308/6/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 341: if self._volfileserver in servers: Line 342: servers.remove(self._volfileserver) Line 343: else: Line 344: self.log.warn("gluster server %r is not in bricks %s, possibly" Line 345: "mounting duplicate servers", self._volfileserver, Keep arguments in separate line: log.warning("message line" "more lines..", arg, arg) And use log.warning - warn works but we try to be consistent: $ git grep 'log\.warning(' | wc -l 121 $ git grep 'log\.warn(' | wc -l 88 Line 346: servers) Line 347: Line 348: if not servers: Line 349: return "" -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
