Francesco Romani has posted comments on this change. Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 2: Code-Review-1 (1 comment) I'm fine with the concept, but I found an unexpected change. Could be intentional, but worth checking. -1 for visibility. https://gerrit.ovirt.org/#/c/48198/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 584: else: : try: : self._threadFactory(partial(self._serveRequest, ctx, request)) : except Exception as e: : self.log.exception("could not allocate request thread") : ctx.requestDone( : JsonRpcResponse( : None, : JsonRpcInternalError( : str(e) : ), : request.id : ) : ) this is surprising - unless I'm missing something huge, I don't see this in the 3.6.x counterpart. Is that intentional? -- To view, visit https://gerrit.ovirt.org/48198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
