Nir Soffer has posted comments on this change. Change subject: iscsi: Fix credentials initialization when not using CHAP ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48483/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 240: password = conDict.get('password') Line 241: if not getattr(password, "value", None): Line 242: password = None Line 243: cred = None Line 244: if username or password There is unintended change here :-) Line 245: cred = iscsi.ChapCredentials(username, password) Line 246: Line 247: params = storageServer.IscsiConnectionParameters(target, iface, cred) Line 248: elif typeName == 'fcp': -- To view, visit https://gerrit.ovirt.org/48483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e1177bc33998b8eba34b0fd04ec62cf8bf1a2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
