Milan Zamazal has posted comments on this change. Change subject: periodic: add executor-compatible naming ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/48193/6/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 262: return '<VmDispatcher operation=%s at 0x%x>' % ( Line 263: self._create, id(self) Line 264: ) Line 265: Line 266: __repr__ = __str__ > Back in time I added __repr__ to have something nicer output in the logs, b Just thought about retaining __repr__ here (as `str' falls back to it), but if you think using __str__ here (and in other classes here) is more appropriate then it's fine for me. Line 267: Line 268: Line 269: class _RunnableOnVm(object): Line 270: Line 292: Line 293: def __str__(self): Line 294: return '<%s vm=%s at 0x%x>' % ( Line 295: self.NAME, self._vm.id, id(self) Line 296: ) Why not simply using self.__class__.__name__ here and introducing NAME? Line 297: Line 298: Line 299: class UpdateVolumes(_RunnableOnVm): Line 300: -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d1180b727571cce34e8304ac48390ed2135f79 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
