Francesco Romani has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/48538/2/vdsm/mkimage.py File vdsm/mkimage.py: Line 127 Line 128 Line 129 Line 130 Line 131 > Must remove isopath here, or creating the iso again will fail because of O_ Good point. Will do. Line 131 Line 132 Line 133 Line 134 Line 135 > Should change isopath to None on failure, so this will not fail trying to c Right, will fix Line 130: Line 131: # pre-create the destination iso path with the right permissions; Line 132: # mkisofs/genisoimage will truncate the content and keep the Line 133: # permissions. Line 134: fd = os.open(isopath, os.O_CREAT | os.O_RDONLY | os.O_EXCL, 0o640) > One issue, if the file exists, the operation will fail. Is this possible wi I can't see a reason for legitimate file to exist, but will double check to make sure Line 135: os.close(fd) Line 136: Line 137: rc, out, err = execCmd(command, raw=True) Line 138: if rc: -- To view, visit https://gerrit.ovirt.org/48538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
