Zhou Zheng Sheng has posted comments on this change.
Change subject: Correct pep8 error- too long line
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File vdsm_cli/vdsClient.py
Line 1888:
'connection=server:/export_path,portal=...,'
Line 1889: 'port=...,iqn=...,user=...,password=...'
Line 1890: '[,initiatorName=...])>',
Line 1891: 'Connect to a storage low level entity
(server)'
Line 1892: )),
This backslash is redundant. (It's not related to this patch. I just happened
to see it.)
Line 1893: 'validateStorageServerConnection': \
Line 1894: (serv.validateStorageServerConnection,
Line 1895: ('<server type> <spUUID> <conList (id=...,'
Line 1896:
'connection=server:/export_path,portal=...,port=...'
Line 2222: 'getVmsInfo': (serv.do_getVmsInfo,
Line 2223: ('<spUUID> [<sdUUID>
[vmList](vmId1,vmId2,...)]',
Line 2224: 'Return info of VMs from the pool or a backup
domain '
Line 2225: 'if its sdUUID is given. If vmList is also
given, '
Line 2226: 'return info for these VMs only.'
Oops, I didn't notice this problem in a previous review on this file.
Line 2227: )),
Line 2228: 'getVmsList': (serv.do_getVmsList,
Line 2229: ('<spUUID> [sdUUID]',
Line 2230: 'Get list of VMs from the pool or domain if
sdUUID '
--
To view, visit http://gerrit.ovirt.org/7760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ecfb6e044537c753f66da8bdf2b6d0597a12446
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Zhu Bo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
