Nir Soffer has posted comments on this change. Change subject: block: add blkdiscard on zero image ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/35631/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 219: size = multipath.getDeviceSize(lvm.lvDmDev(sdUUID, volUUID)) Line 220: Line 221: try: Line 222: misc.ddWatchCopy("/dev/zero", path, aborting, size) Line 223: utillinux.blkdiscard(path) > Are we discarding AFTER we perform the 'dd'? What's the point? We want to remove the data before we discard. Does discard ensure that the data will wiped before this storage area will be used again? Line 224: except Exception as e: Line 225: log.exception('zeroing operation failed') Line 226: raise se.VolumesZeroingError(path) Line 227: -- To view, visit https://gerrit.ovirt.org/35631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e059c556c550440727b36b8af8e5dfc29ce2ccb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
