Yaniv Bronhaim has posted comments on this change. Change subject: stomp: slow data read when connected from localhost ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48608/1/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 354: Line 355: if (parser.pending == 0 and Line 356: size == self._bufferSize and Line 357: dispatcher.socket.getpeername()[0] == '127.0.0.1'): Line 358: self.handle_read(dispatcher) and if it exactly buffer_size msg? what will happen? it looks like weird hack for local communication (worth a comment?) Line 359: except socket.error: Line 360: dispatcher.handle_error() Line 361: return Line 362: -- To view, visit https://gerrit.ovirt.org/48608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
