Nir Soffer has posted comments on this change. Change subject: compat: Use simplejson instead of json ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48565/5/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 29: # We want to work only with simplejson, since the builtin json library Line 30: # likes to convert plain ascii strings to unicode, causing failures when Line 31: # mixing non-ascii string and "unicode" values. Line 32: # See https://bugzilla.redhat.com/1281940 Line 33: import simplejson as json > Why do we still need it in compat? We can update the code to use simplejson It is more flexible when you import json from compat. Now we can change the logic of how we import json without touching any other code. -- To view, visit https://gerrit.ovirt.org/48565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0fb2ac45da86a344be556e6474667650bca966 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
