Yeela Kaplan has posted comments on this change. Change subject: stomp: message tracking do not clean properly ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 328: except KeyError: Line 329: self.log.warn("Missing destination for %s id", response_id) Line 330: Line 331: try: Line 332: connections = self._sub_map[destination] If we had a KeyError in line 326, isn't it possible destination won't be set? Line 333: except KeyError: Line 334: self.log.warn("Attempt to reply to unknown destination %s", Line 335: destination) Line 336: return -- To view, visit https://gerrit.ovirt.org/48616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
