Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48672/1//COMMIT_MSG Commit Message: Line 14: Line 15: As well as for Xen (On Rhel 5.x) Line 16: xen+ssh://user@host Line 17: Line 18: Importing VMs from Xen and Kvm will be presented in the next patches > Can you explain what is the issues in adding this support, and how your pat Done Line 19: Line 20: Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 https://gerrit.ovirt.org/#/c/48672/1/vdsm/v2v.py File vdsm/v2v.py: Line 149: 'message': e.message}} Line 150: Line 151: with closing(conn): Line 152: vms = [] Line 153: for name in conn.listDefinedDomains(): > why is this needed? Could you please elaborate? Not all new methods are supported in older version of libvirt. The methods that I changed are working fine in Rhel 5.x-7.x and checked with Xen, KVM and vCenter Line 154: params = {} Line 155: vm = conn.lookupByName(name) Line 156: _add_vm_info(vm, params) Line 157: try: Line 651: Line 652: Line 653: def _add_vm_info(vm, params): Line 654: params['vmName'] = vm.name() Line 655: if vm.isActive(): > Same: why is this needed? Could you please elaborate? This is the way to know if the VM is up or down, We want to enable importing of VMs that are in status down. the vm.state() is not available for all platforms. Line 656: params['status'] = "Up" Line 657: else: Line 658: params['status'] = "Down" Line 659: Line 689: if 'alias' in disk.keys(): Line 690: try: Line 691: vol = conn.storageVolLookupByPath(disk['alias']) Line 692: _, capacity, alloc = vol.info() Line 693: except libvirt.libvirtError as ex: > useful, and I'm fine with this, but should be split to a separate patch (al sure Line 694: logging.exception("Error getting disk size: %s" % ex.message) Line 695: raise V2VError(ex.message) Line 696: else: Line 697: disk['capacity'] = str(capacity) -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
