Milan Zamazal has posted comments on this change. Change subject: virt: devices: initial support for device updates with etree's ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46525/1/vdsm/virt/domain_descriptor.py File vdsm/virt/domain_descriptor.py: Line 52: return self._devices Line 53: Line 54: def get_device_elements(self, tagName, etree=False): Line 55: return self._elements_by_tag_name(tagName, devices_only=True, Line 56: etree=etree) > Ad etree argument: What are our options? This is probably the primary remaining issue of this patch. Line 57: Line 58: @property Line 59: def devices_hash(self): Line 60: return self._devices_hash -- To view, visit https://gerrit.ovirt.org/46525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7afe81af334ab9d8e7da6626cb902b95202cc05c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches