Nir Soffer has posted comments on this change. Change subject: tests: Test both ssl and m2c ......................................................................
Patch Set 2: (1 comment) Much nicer! but we need also to test no ssl. https://gerrit.ovirt.org/#/c/48823/2/tests/integration/__init__.py File tests/integration/__init__.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from . import m2chelper, sslhelper Can you import m2chelper if M2Crypto is not installed (e.g. on debian)? Line 21: from vdsm import m2cutils, sslutils Line 22: Line 23: Line 24: def get_context(impl): -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches