Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move volumePath and validation ......................................................................
Patch Set 7: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/46383/7/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 190: Line 191: @property Line 192: def volumePath(self): Line 193: if self._volumePath is None: Line 194: self.validateVolumePath() Validate function with side effect?! We need to clean this later. Line 195: return self._volumePath Line 196: Line 197: def getVolumePath(self): Line 198: """ Line 193: if self._volumePath is None: Line 194: self.validateVolumePath() Line 195: return self._volumePath Line 196: Line 197: def getVolumePath(self): Why do we need a java like getter when we have a property?! Need to fix this later. Lets add a TODO file for these cleanups. Can be nice task for for new people. Line 198: """ Line 199: Get the path of the volume file/link Line 200: """ Line 201: if not self._volumePath: -- To view, visit https://gerrit.ovirt.org/46383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b38519df298d6e7b9a4bba2642d615976e0ea04 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
