Adam Litke has uploaded a new change for review. Change subject: build: Use correct equality operator for /bin/test ......................................................................
build: Use correct equality operator for /bin/test According to the man page for 'test', the correct token to use for string equality is '=', not '=='. '==' works for the bash builtin version but we should not depend on it (especially since the pkg-version shebang calls for /bin/sh). This fixes the build on my Ubuntu system. Change-Id: I26c317392a55881f96cb4859db822ecd28cc1a65 Signed-off-by: Adam Litke <[email protected]> --- M build-aux/pkg-version 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/7834/1 diff --git a/build-aux/pkg-version b/build-aux/pkg-version index a8d9d77..346ad23 100755 --- a/build-aux/pkg-version +++ b/build-aux/pkg-version @@ -27,11 +27,11 @@ PKG_VERSION=`cat VERSION 2> /dev/null || git describe --match "v[0-9]*"` -if test "x$1" == "x--full"; then +if test "x$1" = "x--full"; then echo $PKG_VERSION | tr -d '[:space:]' -elif test "x$1" == "x--version"; then +elif test "x$1" = "x--version"; then echo $PKG_VERSION | awk "$AWK_VERSION" | tr -cd '[:alnum:].' -elif test "x$1" == "x--release"; then +elif test "x$1" = "x--release"; then echo $PKG_VERSION | awk "$AWK_RELEASE" | tr -cd '[:alnum:].' else echo "usage: $0 [--full|--version|--release]" -- To view, visit http://gerrit.ovirt.org/7834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26c317392a55881f96cb4859db822ecd28cc1a65 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
